[PATCH] D110623: [SLP] Avoid calculating expensive spill cost when it is not required

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 10:20:38 PST 2022


dtemirbulatov marked an inline comment as done.
dtemirbulatov added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5814-5816
+        if (!isa<DbgInfoIntrinsic>(&*PrevInstIt) &&
+            !(&*PrevInstIt)->isLifetimeStartOrEnd() &&
+            (!II || !II->isAssumeLikeIntrinsic()))
----------------
ABataev wrote:
> I believe `isAssumeLikeIntrinsic()` covers all the checks here, no?
Ah, Correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110623/new/

https://reviews.llvm.org/D110623



More information about the llvm-commits mailing list