[PATCH] D119965: [LICM][PhaseOrder] Don't speculate in LICM until after running loop rotate

[William Moses via Phabricator via llvm-commits]

wsmoses marked 5 inline comments as done.
wsmoses added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:206
+      unsigned LicmMssaNoAccForPromotionCap = SetLicmMssaNoAccForPromotionCap,
+      bool LicmAllowSpeculation = true)
+      : LoopPass(ID), LICM(LicmMssaOptCap, LicmMssaNoAccForPromotionCap,
----------------
lebedev.ri wrote:
> Elsewhere `LicmAllowSpeculation` doesn't have a default value.
> Should we be consistent with that?
This constructor in particular needs a default value since it is constructed without arguments (and all other arguments have default values).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119965/new/

https://reviews.llvm.org/D119965