[PATCH] D112735: export unique symbol list with llvm-nm new option "--export-symbols"

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 08:39:20 PST 2022


DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-nm.rst:280
+
+  Exclude resource file symbols (__rsrc) from export symbol list.
+
----------------
MaskRay wrote:
> 
thanks


================
Comment at: llvm/test/tools/llvm-nm/bitcode-export-sym.test:1
+## Test the "--export-symbols" option with bitcode input files.
+
----------------
MaskRay wrote:
> Add `# REQUIRES: powerpc-registered-target`
I wonder why we need # REQUIRES: powerpc-registered-target here . I think the llvm is cross compile, it can generate the bit code for powerpc on other platform, I added the line anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112735/new/

https://reviews.llvm.org/D112735



More information about the llvm-commits mailing list