[llvm] 0b57e6c - [objcopy] followup patch after f75da0c8e65cf1b09012a8b62cd7f3e9a646bbc9

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 08:36:47 PST 2022


Please use more descriptive commit messages.

In this case, this looks like the original change was incomplete and 
should probably been reverted and reapplied with a fix.

Philip

On 2/17/22 08:33, Alexey Lapshin via llvm-commits wrote:
> Author: Alexey Lapshin
> Date: 2022-02-17T19:32:10+03:00
> New Revision: 0b57e6c46b707c0e7a123efe82abf3c1e7b5a503
>
> URL: https://github.com/llvm/llvm-project/commit/0b57e6c46b707c0e7a123efe82abf3c1e7b5a503
> DIFF: https://github.com/llvm/llvm-project/commit/0b57e6c46b707c0e7a123efe82abf3c1e7b5a503.diff
>
> LOG: [objcopy] followup patch after f75da0c8e65cf1b09012a8b62cd7f3e9a646bbc9
>
> Added:
>      
>
> Modified:
>      clang/docs/tools/clang-formatted-files.txt
>      llvm/unittests/CMakeLists.txt
>
> Removed:
>      
>
>
> ################################################################################
> diff  --git a/clang/docs/tools/clang-formatted-files.txt b/clang/docs/tools/clang-formatted-files.txt
> index 4a2c28bcf32ae..231877144d28a 100644
> --- a/clang/docs/tools/clang-formatted-files.txt
> +++ b/clang/docs/tools/clang-formatted-files.txt
> @@ -5063,6 +5063,18 @@ llvm/include/llvm/MCA/Stages/InstructionTables.h
>   llvm/include/llvm/MCA/Stages/MicroOpQueueStage.h
>   llvm/include/llvm/MCA/Stages/RetireStage.h
>   llvm/include/llvm/MCA/Stages/Stage.h
> +llvm/include/llvm/ObjCopy/MultiFormatConfig.h
> +llvm/include/llvm/ObjCopy/ConfigManager.h
> +llvm/include/llvm/ObjCopy/CommonConfig.h
> +llvm/include/llvm/ObjCopy/ObjCopy.h
> +llvm/include/llvm/ObjCopy/wasm/WasmConfig.h
> +llvm/include/llvm/ObjCopy/wasm/WasmObjcopy.h
> +llvm/include/llvm/ObjCopy/ELF/ELFConfig.h
> +llvm/include/llvm/ObjCopy/ELF/ELFObjcopy.h
> +llvm/include/llvm/ObjCopy/MachO/MachOObjcopy.h
> +llvm/include/llvm/ObjCopy/MachO/MachOConfig.h
> +llvm/include/llvm/ObjCopy/COFF/COFFConfig.h
> +llvm/include/llvm/ObjCopy/COFF/COFFObjcopy.h
>   llvm/include/llvm/Object/Archive.h
>   llvm/include/llvm/Object/COFFModuleDefinition.h
>   llvm/include/llvm/Object/Decompressor.h
> @@ -5766,6 +5778,34 @@ llvm/lib/MCA/Stages/InOrderIssueStage.cpp
>   llvm/lib/MCA/Stages/MicroOpQueueStage.cpp
>   llvm/lib/MCA/Stages/RetireStage.cpp
>   llvm/lib/MCA/Stages/Stage.cpp
> +llvm/lib/ObjCopy/Archive.cpp
> +llvm/lib/ObjCopy/ConfigManager.cpp
> +llvm/lib/ObjCopy/ObjCopy.cpp
> +llvm/lib/ObjCopy/Archive.h
> +llvm/lib/ObjCopy/wasm/Reader.cpp
> +llvm/lib/ObjCopy/wasm/Reader.h
> +llvm/lib/ObjCopy/wasm/Object.cpp
> +llvm/lib/ObjCopy/wasm/Writer.cpp
> +llvm/lib/ObjCopy/wasm/Writer.h
> +llvm/lib/ObjCopy/wasm/Object.h
> +llvm/lib/ObjCopy/wasm/WasmObjcopy.cpp
> +llvm/lib/ObjCopy/ELF/Object.cpp
> +llvm/lib/ObjCopy/MachO/MachOWriter.cpp
> +llvm/lib/ObjCopy/MachO/Object.cpp
> +llvm/lib/ObjCopy/MachO/MachOLayoutBuilder.h
> +llvm/lib/ObjCopy/MachO/MachOWriter.h
> +llvm/lib/ObjCopy/MachO/MachOReader.h
> +llvm/lib/ObjCopy/MachO/MachOReader.cpp
> +llvm/lib/ObjCopy/MachO/Object.h
> +llvm/lib/ObjCopy/MachO/MachOLayoutBuilder.cpp
> +llvm/lib/ObjCopy/MachO/MachOObjcopy.cpp
> +llvm/lib/ObjCopy/COFF/Reader.cpp
> +llvm/lib/ObjCopy/COFF/Reader.h
> +llvm/lib/ObjCopy/COFF/Object.cpp
> +llvm/lib/ObjCopy/COFF/Writer.cpp
> +llvm/lib/ObjCopy/COFF/COFFObjcopy.cpp
> +llvm/lib/ObjCopy/COFF/Writer.h
> +llvm/lib/ObjCopy/COFF/Object.h
>   llvm/lib/Object/Archive.cpp
>   llvm/lib/Object/Binary.cpp
>   llvm/lib/Object/Decompressor.cpp
> @@ -6629,42 +6669,9 @@ llvm/tools/llvm-microsoft-demangle-fuzzer/DummyDemanglerFuzzer.cpp
>   llvm/tools/llvm-microsoft-demangle-fuzzer/llvm-microsoft-demangle-fuzzer.cpp
>   llvm/tools/llvm-ml/Disassembler.h
>   llvm/tools/llvm-modextract/llvm-modextract.cpp
> -llvm/tools/llvm-objcopy/CommonConfig.h
> -llvm/tools/llvm-objcopy/ConfigManager.h
>   llvm/tools/llvm-objcopy/llvm-objcopy.cpp
> -llvm/tools/llvm-objcopy/llvm-objcopy.h
> -llvm/tools/llvm-objcopy/MultiFormatConfig.h
> -llvm/tools/llvm-objcopy/COFF/COFFConfig.h
> -llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp
> -llvm/tools/llvm-objcopy/COFF/COFFObjcopy.h
> -llvm/tools/llvm-objcopy/COFF/Object.cpp
> -llvm/tools/llvm-objcopy/COFF/Object.h
> -llvm/tools/llvm-objcopy/COFF/Reader.cpp
> -llvm/tools/llvm-objcopy/COFF/Reader.h
> -llvm/tools/llvm-objcopy/COFF/Writer.cpp
> -llvm/tools/llvm-objcopy/COFF/Writer.h
> -llvm/tools/llvm-objcopy/ELF/ELFConfig.h
> -llvm/tools/llvm-objcopy/ELF/ELFObjcopy.h
> -llvm/tools/llvm-objcopy/MachO/MachOConfig.h
> -llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp
> -llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.h
> -llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
> -llvm/tools/llvm-objcopy/MachO/MachOObjcopy.h
> -llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
> -llvm/tools/llvm-objcopy/MachO/MachOReader.h
> -llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp
> -llvm/tools/llvm-objcopy/MachO/MachOWriter.h
> -llvm/tools/llvm-objcopy/MachO/Object.cpp
> -llvm/tools/llvm-objcopy/MachO/Object.h
> -llvm/tools/llvm-objcopy/wasm/Object.cpp
> -llvm/tools/llvm-objcopy/wasm/Object.h
> -llvm/tools/llvm-objcopy/wasm/Reader.cpp
> -llvm/tools/llvm-objcopy/wasm/Reader.h
> -llvm/tools/llvm-objcopy/wasm/WasmConfig.h
> -llvm/tools/llvm-objcopy/wasm/WasmObjcopy.cpp
> -llvm/tools/llvm-objcopy/wasm/WasmObjcopy.h
> -llvm/tools/llvm-objcopy/wasm/Writer.cpp
> -llvm/tools/llvm-objcopy/wasm/Writer.h
> +llvm/tools/llvm-objcopy/ObjcopyOptions.cpp
> +llvm/tools/llvm-objcopy/ObjcopyOptions.h
>   llvm/tools/llvm-objdump/COFFDump.h
>   llvm/tools/llvm-objdump/ELFDump.h
>   llvm/tools/llvm-objdump/MachODump.h
> @@ -6916,6 +6923,7 @@ llvm/unittests/MC/MCInstPrinter.cpp
>   llvm/unittests/MC/TargetRegistry.cpp
>   llvm/unittests/MC/AMDGPU/DwarfRegMappings.cpp
>   llvm/unittests/MC/SystemZ/SystemZAsmLexerTest.cpp
> +llvm/unittests/ObjCopy/ObjCopyTest.cpp
>   llvm/unittests/Object/ArchiveTest.cpp
>   llvm/unittests/Object/ELFTest.cpp
>   llvm/unittests/Object/ELFTypesTest.cpp
>
> diff  --git a/llvm/unittests/CMakeLists.txt b/llvm/unittests/CMakeLists.txt
> index 6f4df5b585bf6..99782949b2559 100644
> --- a/llvm/unittests/CMakeLists.txt
> +++ b/llvm/unittests/CMakeLists.txt
> @@ -35,6 +35,7 @@ add_subdirectory(Linker)
>   add_subdirectory(MC)
>   add_subdirectory(MI)
>   add_subdirectory(MIR)
> +add_subdirectory(ObjCopy)
>   add_subdirectory(Object)
>   add_subdirectory(ObjectYAML)
>   add_subdirectory(Option)
>
>
>          
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list