[PATCH] D119974: [NFC][llvm-nm] refactor function dumpSymbolNamesFromFile

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 07:10:27 PST 2022


jhenderson accepted this revision.
jhenderson added a comment.

Looks good, with the suggested comment rewrite.



================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:2037-2038
+
+// If there is object which's arch name matchs the host arch name, return
+// true, otherwise return false.
+static bool dumpMachOUniversalBinaryMatchHost(MachOUniversalBinary *UB,
----------------
(and reflow as necesary).

I've taken the wording from a similar comment elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119974/new/

https://reviews.llvm.org/D119974



More information about the llvm-commits mailing list