[PATCH] D120051: [flang][driver] Make `flang-new` always generate run-time type info

[Jean Perier via Phabricator via llvm-commits]

jeanPerier added a subscriber: klausler.
jeanPerier added inline comments.


================
Comment at: flang/include/flang/Frontend/FrontendActions.h:138
+// This can be useful when adding new languge feature and when you wish to
+// investigate compiler output (e.g. the parse tree) despite any semantinc
+// errors.
----------------
`semantinc` -> `semantic`


================
Comment at: flang/lib/Frontend/FrontendAction.cpp:191
+  // semantic errors. Report them.
+  if (reportFatalSemanticErrors()) {
+    return false;
----------------
@klausler , do can you confirm the runtime type info generation will not generate bogus semantics errors ?


================
Comment at: flang/lib/Frontend/FrontendAction.cpp:194
+  }
+
+  return true;
----------------
I wonder if you should not always complain here if `!ci.getRtTyTables().schemata`. Currently, it seems `DebugDumpSymbolsAction` and `DebugDumpSymbolsAction` would complain. I think at least the regular
compiler workflows should complain if it was not able to generate those. Better than to wait for more cryptic link time errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120051/new/

https://reviews.llvm.org/D120051