[PATCH] D88827: [llvm-objcopy][NFC] Move core implementation of llvm-objcopy into separate library.

Thu Feb 17 05:53:57 PST 2022

thakis added a comment.

As far as I know, you also have to update the entries in clang/docs/tools/clang-formatted-files.txt.

================
Comment at: llvm/lib/CMakeLists.txt:24
 add_subdirectory(MCA)
+add_subdirectory(ObjCopy)
 add_subdirectory(Object)
----------------
Can we be consistent about capitalization of "ObjCopy" or "Objcopy"? The new lib capitalizes the C, but e.g. `ObjcopyOptions.cpp` doesn't. (Don't care which way, just be consistent).

```
% git grep Objcopy | wc -l
     150
% git grep ObjCopy | wc -l
      77
```

================
Comment at: llvm/unittests/ObjCopy/CMakeLists.txt:1
+set(LLVM_LINK_COMPONENTS
+  Object
----------------
I think you have to add_subdirectory this in llvm/unittests/CMakeLists.txt to get this test binary actually built.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88827/new/

https://reviews.llvm.org/D88827