[PATCH] D112429: [ARM] Implement PAC return address signing mechanism for PACBTI-M

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 04:57:04 PST 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:4539
+          (Reg != ARM::RA_AUTH_CODE && !RC->contains(Reg)))
         return Error(AfterMinusLoc, "invalid register in register list");
       // Ranges must go from low to high.
----------------
@stuij Static analysis is warning about dead code here - we've already handled the Reg == ARM::RA_AUTH_CODE case at line 4519, should this just be:
```
if (!RC->contains(Reg))
  return Error(AfterMinusLoc, "invalid register in register list");
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112429/new/

https://reviews.llvm.org/D112429



More information about the llvm-commits mailing list