[PATCH] D119965: [LICM][PhaseOrder] Don't speculate LICM until after running loop rotate

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 04:14:06 PST 2022


lebedev.ri added a comment.

In D119965#3327448 <https://reviews.llvm.org/D119965#3327448>, @lebedev.ri wrote:

> D119975 <https://reviews.llvm.org/D119975>

Ok, that doesn't work.

Please rebase this patch, and update affected tests (no new tests are needed here):

- the subject is missing "in" before "LICM"
- The parameter name should be `AllowSpeculation`, it should be `bool`.



================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:294
   // Try to remove as much code from the loop header as possible,
   // to reduce amount of IR that will have to be duplicated.
   // TODO: Investigate promotion cap for O1.
----------------
Please update the comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119965/new/

https://reviews.llvm.org/D119965



More information about the llvm-commits mailing list