[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind
Momchil Velikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 17 02:45:59 PST 2022
chill added inline comments.
================
Comment at: llvm/lib/IR/Attributes.cpp:453
+ return "uwtable";
+ return ("uwtable(" + Twine(Kind == UWTableKind::Sync ? "sync" : "async") +
+ ")")
----------------
RKSimon wrote:
> @chill Static analysis is warning that its impossible to hit the if(Kind == Default) case here - it looks like you have merged 2 versions of the same (Kind != UWTableKind::None) handling code?
Thanks, indeed.
Fixed in https://reviews.llvm.org/D120030
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114543/new/
https://reviews.llvm.org/D114543
More information about the llvm-commits
mailing list