[PATCH] D119974: [NFC][llvm-nm] refactor function dumpSymbolNamesFromFile

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks good, with one request though.



================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:2037
+
+static bool dumpMachOUniversalBinaryMatchHost(MachOUniversalBinary *UB,
+                                              std::string &Filename,
----------------
Might be worth a comment saying what the boolean return indicates.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119974/new/

https://reviews.llvm.org/D119974