[PATCH] D119901: [Debuginfod] Add BUILD_ID syntax to llvm-symbolizer.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-symbolizer.rst:113-121
+  $ llvm-symbolizer "test.elf 0x400490" "FILE:inlined.elf 0x400480"
   baz()
   /tmp/test.cpp:11:0
 
   foo()
   /tmp/test.cpp:8:10
 
----------------
Rather than add `FILE:` prefixes here, I'd instead modify Example 4 to say "BUILDID and FILE prefixes" or similar, like Example 5's "CODE and DATA prefixes".


================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:149-150
   if (BinaryName.empty() && BuildID.empty()) {
+    bool NameIsBuildID = !InputString.consume_front("FILE:") &&
+                         InputString.consume_front("BUILDID:");
+    Pos = InputString.data();
----------------
This piece of code makes me wonder whether a test case with something like `FILE:BUILDID:<hex>` and/or `BUILDID:FILE:<path>` or similar might be useful. Not sure either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119901/new/

https://reviews.llvm.org/D119901