[PATCH] D119886: [AMDGPU] Promote recursive loads from kernel argument to constant

[Valery Pykhtin via Phabricator via llvm-commits]

vpykhtin accepted this revision.
vpykhtin added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteKernelArguments.cpp:155
+  PointerType *NewPT =
+      PointerType::getWithSamePointeeType(PT, AMDGPUAS::CONSTANT_ADDRESS);
+  Value *Cast = B.CreateAddrSpaceCast(OrigPtr, NewPT,
----------------
I'm not sure if this would be easier to understand if you use Ptr->getType() here as you checked its the same as OrigPtr->getType()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119886/new/

https://reviews.llvm.org/D119886