[PATCH] D119127: Preserve inbounds information of GEP during Argument Promotion Pass across callee and its callers.

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 16 23:21:45 PST 2022


vpykhtin added a comment.

Using IsArgGepInBound map just to hold a boolean seems expensive to me, can you just add a field to OriginalLoads value?



================
Comment at: llvm/lib/Transforms/IPO/ArgumentPromotion.cpp:201
+        // callers of current function
+        const GEPOperator *GEPOp = dyn_cast_or_null<GEPOperator>(UI);
+        if (GEPOp) {
----------------
UI isn't expected to be null here, dyn_cast should be enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119127/new/

https://reviews.llvm.org/D119127



More information about the llvm-commits mailing list