[PATCH] D119658: [BOLT][NFC] Report errors from createBinaryContext and RewriteInstance ctor

[Rafael Auler via Phabricator via llvm-commits]

rafauler accepted this revision.
rafauler added a comment.
This revision is now accepted and ready to land.

Sounds good. There is one nit to fix.



================
Comment at: bolt/include/bolt/Rewrite/RewriteInstance.h:47
   RewriteInstance(llvm::object::ELFObjectFileBase *File, const int Argc,
-                  const char *const *Argv, StringRef ToolPath);
+                  const char *const *Argv, StringRef ToolPath, Error &Err);
+  static Expected<std::unique_ptr<RewriteInstance>>
----------------
Insert a newline after this line to mirror MachORewriteInstance.h


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119658/new/

https://reviews.llvm.org/D119658