[PATCH] D119934: [RISCV] Fix a mistake in PostprocessISelDAG
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 16 18:20:25 PST 2022
craig.topper added a comment.
In D119934#3328030 <https://reviews.llvm.org/D119934#3328030>, @jrtc27 wrote:
> In D119934#3328022 <https://reviews.llvm.org/D119934#3328022>, @craig.topper wrote:
>
>> I suppose we inherited this bug from PowerPC. @nemanjai maybe you want to fix this for PowerPC?
>
> X86 is the same from the looks of it. The only other implementation of PostprocessISelDAG is AMDGPU which does things a bit differently and doesn't seem to have an equivalent "check for uses".
With the current post-processing on X86 I don't thin you could get a failure. None of the opcodes that are being looked for have chain outputs so they can't be the root.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119934/new/
https://reviews.llvm.org/D119934
More information about the llvm-commits
mailing list