[PATCH] D117733: [RISCV] Update Privileged spec to version-20211203: Support Hypervisor Extention

Wed Feb 16 18:17:58 PST 2022

tangxingxin1008 added a comment.

In D117733#3266007 <https://reviews.llvm.org/D117733#3266007>, @asb wrote:

> Thanks for the patch. Alongside the inline comments, two minor suggestions:
>
> - There's no need to split it out now I don't think, but the GPRAtomicMemOp->GPRMemZeroOffset is a change that could have been split out to a separate commit and reviewed separately.
> - We don't do enough testing for this in general I don't think, but it would be good to add tests that attempting to use the RV64-only hypervisor instructions on RV32 produces an error.
>
> Once the inline comments are addressed and tests added for using the RV64 instructions on RV32, I think it should be ready to land.

" There's no need to split it out now I don't think", do you mean the two commits [D117654 <https://reviews.llvm.org/D117654>, D117733 <https://reviews.llvm.org/D117733>]  should be to one commit?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117733/new/

https://reviews.llvm.org/D117733