[PATCH] D119905: [X86ISelLowering] permit BlockAddressSDNode "i" constraints for PIC

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added a comment.

In D119905#3327353 <https://reviews.llvm.org/D119905#3327353>, @efriedma wrote:

> I think there are other issues with this code; it isn't handling all the patterns that it should.  See immediate handling in TargetLowering::LowerAsmOperandForConstraint.

Luckily, the target specific overrides defer to the base classes method (by explicitly calling `TargetLowering::LowerAsmOperandForConstraint` from `X86TargetLowering::LowerAsmOperandForConstraint`. It's below the fold of what phab shows, but it's just a few lines down from my hunk if you expand the view in phab.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119905/new/

https://reviews.llvm.org/D119905