[PATCH] D119854: [SimplifyCFG][PhaseOrdering] Defer lowering switch into an integer range comparison and branch until after at least the IPSCCP

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/SimplifyCFGOptions.h:26
   bool ForwardSwitchCondToPhi = false;
+  bool ConvertSwitchRangeToICmp = false;
   bool ConvertSwitchToLookupTable = false;
----------------
nikic wrote:
> As we want to disable this essentially only for the first SimplifyCFG run, may make the default true?
I acknowledge that this is a tricky question,
but opting-into something lossy seems better
than ensuring that we opt-out everywhere,
so i've gone with that.
I don't think there is The Right choice here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119854/new/

https://reviews.llvm.org/D119854