[PATCH] D119905: [X86ISelLowering] permit BlockAddressSDNode "i" constraints for PIC

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I don't think you need to check that the blockaddress refers to the current function. A blockaddress always refers to the version of the function in the current file (similar to the way an alias works).  So the address is always going to be valid; you never have to go through a GOT or anything like that.

I think there are other issues with this code; it isn't handling all the patterns that it should.  See immediate handling in TargetLowering::LowerAsmOperandForConstraint.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119905/new/

https://reviews.llvm.org/D119905