[PATCH] D119475: [AMDGPU] Add scheduler pass to rematerialize trivial defs

Vang Thao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 16 12:16:53 PST 2022


vangthao updated this revision to Diff 409362.
vangthao marked 12 inline comments as done.
vangthao added a comment.

Added static_assert requring that PreRARematerialize is the last pass. Check RegionEnd for region we are sinking from. Added two tests to check for RegionIdx being incremented correctly when a region is reduced to size 0 or 1. Erase high rp region from MBBLiveIns after sinking since it is now invalid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119475/new/

https://reviews.llvm.org/D119475

Files:
  llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp
  llvm/lib/Target/AMDGPU/GCNSchedStrategy.h
  llvm/test/CodeGen/AMDGPU/dbg-value-ends-sched-region.mir
  llvm/test/CodeGen/AMDGPU/debug-value-scheduler-crash.mir
  llvm/test/CodeGen/AMDGPU/machine-scheduler-sink-trivial-remats.mir
  llvm/test/CodeGen/AMDGPU/sched-assert-dead-def-subreg-use-other-subreg.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119475.409362.patch
Type: text/x-patch
Size: 366076 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220216/9eeccdf1/attachment-0001.bin>


More information about the llvm-commits mailing list