[PATCH] D119962: [ifs] Add --preserve flag for keeping symbols that would be removed by --strip-undefined

Haowei Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 16 11:51:53 PST 2022


haowei added inline comments.


================
Comment at: llvm/tools/llvm-ifs/llvm-ifs.cpp:298
 
+static Error stripSyms(IFSStub &Stub) {
+  std::function<bool(const IFSSymbol &)> Filter = [](const IFSSymbol &) {
----------------
I think it is better to put this back into the IFSHandler.cpp. That file is part of the InterfaceStub library so it can be used by other tools in the future. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119962/new/

https://reviews.llvm.org/D119962



More information about the llvm-commits mailing list