[PATCH] D119907: [ifs] Add --strip-needed flag

[Haowei Wu via Phabricator via llvm-commits]

haowei added inline comments.


================
Comment at: llvm/tools/llvm-ifs/llvm-ifs.cpp:106
                    cl::cat(IfsCategory));
+cl::opt<bool> StripIFSNeededLibs("strip-needed",
+                                 cl::desc("Strip needed libs from IFS output"),
----------------
abrachet wrote:
> haowei wrote:
> > Since this flag affects both IFS output as well as ELF output. I think it is better to rename this variable to `StripNeededLibs`
> Done. Out of curiosity is there a reason that these other flags are only meaningful when outputting ifs? Why not have strip-undefined strip undefined syms when outputting elf stubs too?
At the time when it was implemented, we thought it was unnecessary. So it only applied to IFS file. I guess it is OK to make the flag applies to the ELF as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119907/new/

https://reviews.llvm.org/D119907