[PATCH] D119908: [ELF] Move duplicate symbol check after input file parsing

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 3 inline comments as done.
MaskRay added inline comments.


================
Comment at: lld/ELF/Driver.cpp:2309-2310
+  });
+  for (BitcodeFile *file : bitcodeFiles)
+    file->postParse();
+
----------------
ikudrin wrote:
>  - Why no parallel execution for bitcode files?
>  - Shouldn't this loop be placed later in the function to detect duplicate symbols if some bitcode files are parsed after this point? They may define an `--entry` symbol, as an example.
Added. Because I thought the code size may not justify the very little performance improvement... With LTO, symbol resolution takes a very tiny time.
That said, the code of parallelForEach has been significantly lowered by D117510, so perhaps just simply add it even if the gain is very low.

--entry is a good point. I added a similar --undefined-glob test to lto/duplicated.ll


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119908/new/

https://reviews.llvm.org/D119908