[PATCH] D119884: [llvm] [bindings/OCaml] Remove unused dep on ounit2

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 16 10:17:59 PST 2022


mgorny added a comment.

In D119884#3326249 <https://reviews.llvm.org/D119884#3326249>, @jberdine wrote:

> Note that it was @arbipher who first noticed that ounit is no longer used.

Ok, thanks for the correction and sorry for the mistake.

In D119884#3326515 <https://reviews.llvm.org/D119884#3326515>, @arbipher wrote:

> My 5 cent (for ocaml) is to keep it and it would be easier to really add some useful ounit tests, however, this PR also has shown what needs to do to revert it back.

Yeah, we can easily revert this if we ever introduce ounit-based tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119884/new/

https://reviews.llvm.org/D119884



More information about the llvm-commits mailing list