[PATCH] D119074: [ELF] Parse archives as --start-lib object files

Wed Feb 16 09:59:39 PST 2022

jhenderson added a comment.

In D119074#3326828 <https://reviews.llvm.org/D119074#3326828>, @aeubanks wrote:

> In D119074#3326772 <https://reviews.llvm.org/D119074#3326772>, @jhenderson wrote:
>
>> In D119074#3326760 <https://reviews.llvm.org/D119074#3326760>, @aeubanks wrote:
>>
>>> Unsupporting the test on Windows is fine, I can send out a patch.
>>> We can't change gnuwin32 and it's what all the LLVM docs say to use, so we have to deal with it.
>>
>> Which docs are you referring to? The latest LLVM docs no longer say to use GNUWin32 (because it's so old). See D108513 <https://reviews.llvm.org/D108513>. The consensus nowadays seems to be to rely on the tools shipped with git.
>
> Ah I do vaguely remember that patch going through.
> I grepped for `gnuwin` and saw a bunch of references to it, all of them saying/implying that we should be using gnuwin. Perhaps those should be updated?

Yes, probably!

> The thing with git bash tools is that although they're great for development, it's non trivial to download them and unpack them somewhere as part of bot builds.

Don't these bots need git installed already though to checkout the LLVM repository?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119074/new/

https://reviews.llvm.org/D119074