[PATCH] D119074: [ELF] Parse archives as --start-lib object files
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 16 09:31:10 PST 2022
aeubanks added a comment.
In D119074#3326697 <https://reviews.llvm.org/D119074#3326697>, @MaskRay wrote:
> In D119074#3326237 <https://reviews.llvm.org/D119074#3326237>, @thakis wrote:
>
>> Hooray for the speedup!
>>
>> Looks like this breaks tests on Windows though: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8822094137116818593/+/u/package_clang/stdout?format=raw
>>
>> tail: cannot open `+9' for reading: No such file or directory
>>
>> Looks like the gnuwin version of tail doesn't like `-c +9` syntax. Is there a different way of writing this?
>
> The `-c +9` usage conforms to https://pubs.opengroup.org/onlinepubs/007904975/utilities/tail.html
>
> We can unsupport the test on Windows. Is it that old? http://gnuwin32.sourceforge.net/packages/coreutils.htm
Unsupporting the test on Windows is fine, I can send out a patch.
We can't change gnuwin32 and it's what all the LLVM docs say to use, so we have to deal with it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119074/new/
https://reviews.llvm.org/D119074
More information about the llvm-commits
mailing list