[PATCH] D119955: [InstCombine] push constant operand down/outside in sequence of min/max intrinsics

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:924
+  if (!InnerMM || InnerMM->getIntrinsicID() != MinMaxID ||
+      match(X, m_Constant()) || match(Y, m_Constant()))
+    return nullptr;
----------------
lebedev.ri wrote:
> Constant or ImmConstant?
I figured any constant would be safer. I'm not sure what happens if we put constant expressions in these patterns, so just give up?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119955/new/

https://reviews.llvm.org/D119955