[PATCH] D119941: [CodeGen] Return false from LiveIntervals::runOnMachineFunction

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 16 09:21:47 PST 2022


myhsu added a comment.

In D119941#3326565 <https://reviews.llvm.org/D119941#3326565>, @foad wrote:

>> I've got the feeling that we could do something at the analysis level to make sure we never return true for an analysis.
>
> Maybe, but I thought the legacy pass manager generally did not distinguish analysis passes from non-analysis passes.

maybe we can use `PassInfo::isAnalysis()`?

> I think we could also use hashing on MachineFunctions to check for MachineFunctionPasses that modify the MF and then return false.

I vaguely remember a similar idea was also proposed for the new PassManager, couldn't find it on the mailing list (archive) though


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119941/new/

https://reviews.llvm.org/D119941



More information about the llvm-commits mailing list