[PATCH] D119886: [AMDGPU] Promote recursive loads from kernel argument to constant

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteKernelArguments.cpp:133
+  PointerType *PT = cast<PointerType>(Ptr->getType());
+  if (PT->getAddressSpace() == AMDGPUAS::CONSTANT_ADDRESS)
+    return false;
----------------
vpykhtin wrote:
> Nit: you can leave only the same check after the loop below
Not really. First check is if the original pointer is already a constant address space, the one below is it was cast from constant. In either case we need to bail.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteKernelArguments.cpp:138
+  Value *OrigPtr = Ptr;
+  while (isa<AddrSpaceCastInst>(OrigPtr))
+    OrigPtr = cast<AddrSpaceCastInst>(OrigPtr)->getPointerOperand();
----------------
vpykhtin wrote:
> Nit: you can shorten the loop unsing while (auto *P = dyn_cast<AddrSpaceCastInst>(OrigPtr)) ...
I need both Ptr and OrigPtr after the loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119886/new/

https://reviews.llvm.org/D119886