[PATCH] D119912: Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:90
     const GCNSubtarget &ST, int32_t ArgNumAGPR, int32_t ArgNumVGPR) const {
-  if (ST.hasGFX90AInsts() && ArgNumAGPR)
-    return alignTo(ArgNumVGPR, 4) + ArgNumAGPR;
-  return std::max(ArgNumVGPR, ArgNumAGPR);
+  return llvm::AMDGPU::getTotalNumVGPRs(
+    ST.hasGFX90AInsts(), ArgNumAGPR, ArgNumVGPR);
----------------
Don't need llvm::


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1525
+int32_t getTotalNumVGPRs(bool has90AInsts, int32_t ArgNumAGPR,
+                     int32_t ArgNumVGPR) {
+  if (has90AInsts && ArgNumAGPR)
----------------
Formatting


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119912/new/

https://reviews.llvm.org/D119912