[PATCH] D119929: [MemCpyOpt] Check uses of found Clobber in writtenBetween.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 16 05:32:58 PST 2022


nikic added a comment.

I'm not sure this is the right approach. The `getDefininingAccess()` here is essentially only supposed to skip over End itself during the clobber walk. As you correctly note, this is not correct if End is a MemoryUse. But shouldn't we be able to still do basically the same thing, but with the previous def in the block? Something like stepping one back on `getReverseDefsIterator()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119929/new/

https://reviews.llvm.org/D119929



More information about the llvm-commits mailing list