[PATCH] D119760: [DSE] Fall back to CFG scan for unreachable terminators.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1525
+      if (!AllPathsToExitThroughCommonPred && !AnyUnreachableExit)
         return None;
 
----------------
nikic wrote:
> Should be sufficient to only change this branch?
> ```
> if (!PDT.dominates(CommonPred, MaybeDeadAccess->getBlock())) {
>   // Comment
>   if (!AnyUnreachableExit)
>     return None;
>   CommonPred = nullptr;
> }
> ```
Good point, updated as suggested, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119760/new/

https://reviews.llvm.org/D119760