[PATCH] D119336: [AArch64][SVE] Avoid multiple PTRUE values for SETCC.

Wed Feb 16 02:45:21 PST 2022

peterwaller-arm added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:2386
 static SDValue getPredicateForScalableVector(SelectionDAG &DAG, SDLoc &DL,
                                              EVT VT);

----------------
Note: Block of similar forward decls here.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:17092-17093

+static SDValue getPredicateForFixedLengthVector(SelectionDAG &DAG, SDLoc &DL,
+                                                EVT VT);
+// Pattern match utility function to return if V is a conversion of a
----------------
Nit. Is this the right place for this forward declaration? It's not used in the function immediately below. I see a block of forward decls above.

================
Comment at: llvm/test/CodeGen/AArch64/sve-setcc.ll:119
+; Make sure that only a single PTRUE instruction is generated (to avoid having both a `ptrue p0.s` and a `ptrue p0.s, vl16` for the different operations).
+define <vscale x 16 x i1> @foo(<vscale x 16 x i8> %other, <16 x i8> %subvec) {
+; CHECK-LABEL: foo:
----------------
Looks like a draft function name slipped in here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119336/new/

https://reviews.llvm.org/D119336