[PATCH] D88827: [llvm-objcopy][NFC] Move core implementation of llvm-objcopy into separate library.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two nits.



================
Comment at: llvm/include/llvm/ObjCopy/ObjCopy.h:22-27
+/// Applies the transformations described by \p Config to
+/// each member in archive \p Ar.
+/// \returns Vector of transformed archive members.
+Expected<std::vector<NewArchiveMember>>
+createNewArchiveMembers(const MultiFormatConfig &Config,
+                        const object::Archive &Ar);
----------------
This doesn't need to be in the header, right? I'd get rid of it, as it's not really part fo the public interface (`executeObjcopyOnArchive` would be the right thing to use, I believe(?)).


================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:20
+#include "llvm/ObjCopy/wasm/WasmObjcopy.h"
 
 #include "llvm/ADT/STLExtras.h"
----------------
Delete this blank line then resort the headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88827/new/

https://reviews.llvm.org/D88827