[PATCH] D119665: [M68k] Adopt VarLenCodeEmitter for control instructions
Min-Yih Hsu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 15 20:28:14 PST 2022
myhsu accepted this revision.
myhsu added a comment.
This revision is now accepted and ready to land.
LGTM
please address my last comment before commit though
================
Comment at: llvm/lib/Target/M68k/M68kInstrControl.td:167
+ // FIXME: If we want to avoid supplying disp_16_32 with empty
+ // (ascend) for 16/32 bits variants, we can we conditional
+ // bang operator like this:
----------------
"we can we conditional"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119665/new/
https://reviews.llvm.org/D119665
More information about the llvm-commits
mailing list