[PATCH] D119689: [InstCombine] Add test reproducing PR53252 (NFC)

Ricky Zhou via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 15 16:25:47 PST 2022


rickyz added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/canonicalize-clamp-like-pattern-between-negative-and-positive-thresholds.ll:201
+  %t2 = icmp ugt i32 %x, 128
+  %r = select i1 %t2, i32 %x, i32 %t1
+  ret i32 %r
----------------
I omitted the constant offset on x (add i32 %x, C0) in these tests because other transformations that these tests aren't trying to exercise would rewrite them. Happy to add them if preferred - it'd just mean that changes to those other transformations would cause churn in these tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119689/new/

https://reviews.llvm.org/D119689



More information about the llvm-commits mailing list