[PATCH] D119577: [BOLT][DWARF] Add ability to insert new entries in to DIE

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/include/bolt/Core/DebugData.h:666
 
+  /// Inserts a new uint32_t \p Value at the end of \p DIE .
+  void insertNewEntry(const DWARFDie &DIE, uint32_t);
----------------



================
Comment at: bolt/include/bolt/Core/DebugData.h:669
+
+  /// Inserts a new encoded \p Value at the end of \p DIE .
+  void insertNewEntry(const DWARFDie &DIE, std::string &&Value);
----------------



================
Comment at: bolt/lib/Core/DebugData.cpp:422
 
+static std::string encodeLE(size_t ByteSize, uint64_t NewValue) {
+  std::string LE64(ByteSize, 0);
----------------
We need a proper way to handle endianness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119577/new/

https://reviews.llvm.org/D119577