[PATCH] D119802: [HWASan] remove replacement of DbgVariableIntrinsics.

Tue Feb 15 11:18:30 PST 2022

fmayer added a comment.

In D119802#3323886 <https://reviews.llvm.org/D119802#3323886>, @eugenis wrote:

> In D119802#3321609 <https://reviews.llvm.org/D119802#3321609>, @fmayer wrote:
>
>> In D119802#3321598 <https://reviews.llvm.org/D119802#3321598>, @fmayer wrote:
>>
>>> Oh hold on, maybe what we actually want (to fix this) is to replace `NewPtr` (the BitCast from `alignAndPadAlloca`) with `Info.AI`. Sorry for jumping the gun here, the change as is is correct in that it keeps current behaviour, but that is possibly not what we want.
>>
>> Nevermind, no. We actually want the cast, because otherwise we cast to the (wrong) type of the padded alloca; or at least that's what the test in asserting. Correct me if that's wrong.
>
> Which test?

llvm/test/Instrumentation/HWAddressSanitizer/dbg-value-tag-offset.ll

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119802/new/

https://reviews.llvm.org/D119802