[PATCH] D118299: [Spill2Reg][2/9] This patch adds spill/reload collection.

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo marked an inline comment as done.
vporpo added inline comments.


================
Comment at: llvm/lib/CodeGen/Spill2Reg.cpp:160
+        auto &Entry = StackSlotData[StackSlot];
+        unsigned MemBits = TRI->getRegSizeInBits(MO->getReg(), *MRI);
+        if (SkipEntry(StackSlot, MemBits, MI.getOpcode())) {
----------------
arsenm wrote:
> I wouldn't assume the memory size is the same as the register size
Perhaps the variable name is bad. MemBits is the size of the register and we are using it later in the code generation phase to choose which insert/extract instruction to use. 
Wdyt about renaming it to SpillBits ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118299/new/

https://reviews.llvm.org/D118299