[PATCH] D119053: [nfc][codegen] Move RegisterBank[Info].cpp under CodeGen

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 15 10:14:37 PST 2022


mtrofin added a comment.

In D119053#3323575 <https://reviews.llvm.org/D119053#3323575>, @myhsu wrote:

> Just want to double check: You have a (possibly downstream) use case that wants to leverage RegisterBank without linking GlobalISel, is that correct?

Yes, a subsequent change would do that: add bank-ness info as a feature to the ML eviction advisor.

> My two-cent is that since none of the upstream code uses RegisterBank outside GlobalISel context, I don't see much justification on making this change. That said, if this situation changes in the upstream in the future (i.e. some other components also use RegisterBank) moving to CodeGen might be a way.

It could help others, too, hence wanted to introduce this "for its own merit" - i.e. the justification being cleanup (architectural, in this case).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119053/new/

https://reviews.llvm.org/D119053



More information about the llvm-commits mailing list