[PATCH] D119818: [MemoryDepndency] Relax the re-ordering with volatile store.

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/required changes pre-commit.



================
Comment at: llvm/test/Analysis/MemoryDependenceAnalysis/reorder-volatile.ll:11
+define i32 @test_load() {
+; CHECK-LABEL: @test_load(
+; CHECK: ret i32 %lv
----------------
Autogen this please.  And precommit the test before landing the change.


================
Comment at: llvm/test/Analysis/MemoryDependenceAnalysis/reorder-volatile.ll:29
+ ret i32 %res
+}
----------------
Please add a test with a volatile load wrapped between two acquires, and a separate one with it wrapped by seq_cst loads.  They *should not* fold.  (Well, with the current logic at least.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119818/new/

https://reviews.llvm.org/D119818