[PATCH] D118981: [VP] Condition in vp.select|merge not a VP mask

Tue Feb 15 07:41:37 PST 2022

frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

In D118981#3311747 <https://reviews.llvm.org/D118981#3311747>, @simoll wrote:

> In D118981#3305224 <https://reviews.llvm.org/D118981#3305224>, @frasercrmck wrote:
>
>> Makes sense to me: it's not a mask. I was looking around to see what knock-on effects this has, and good news is that I think this fixes a bug we're not testing where an all-zeros "mask" will DAGCombine to `undef` (`visitVPOp`). Could you maybe pre-commit a test for that and show this patch fixing it?
>>
>> On that note: I don't know if this is truly a child of D105283 <https://reviews.llvm.org/D105283>. Can't we merge it right away?
>
> Actually, DAGCombine won't do that because it only folds bvp inary operators mem ops and reduction. So, also nothing to test.

Yes, you're right, sorry. `visitVPOp` is more careful than I thought.

LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118981/new/

https://reviews.llvm.org/D118981