[PATCH] D117612: [BOLT] Update dynamic relocations from section relocations

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 15 05:37:41 PST 2022


yota9 added a comment.

@maksfb Thank you for your review and valuable comments! :)



================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:4755
+        cantFail(Section->getSectionRef().getContents());
+    Start = SectionContents.data() - File->getData().data();
+    End = Start + Section->getSize();
----------------
maksfb wrote:
> Can you use `Section->getInputFileOffset()`?
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117612/new/

https://reviews.llvm.org/D117612



More information about the llvm-commits mailing list