[PATCH] D119754: [InstCombine] reassociate min/max intrinsics with constant operands

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 15 05:09:53 PST 2022


spatel added a comment.

In D119754#3322285 <https://reviews.llvm.org/D119754#3322285>, @nikic wrote:

> LGTM
>
> I think additional reassociation is not really a requirement here, and probably InstCombine is not the right place to reassociate large chains.

I think it's good to make that an incremental improvement. It's not a lot of work to implement a variation of the suggested generalization -- I already drafted it. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119754/new/

https://reviews.llvm.org/D119754



More information about the llvm-commits mailing list