[PATCH] D119750: [AMDGPU] Pre-commit test for wait between agpr & vgpr

Tue Feb 15 02:54:14 PST 2022

foad added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/waitcnt-agpr.mir:65
+  ; GCN-NEXT:   successors: %bb.1(0x80000000)
+  ; GCN-NEXT: {{  $}}
+  ; GCN-NEXT:   S_WAITCNT 0
----------------
rampitec wrote:
> Joe_Nash wrote:
> > Joe_Nash wrote:
> > > Why are these {{ $}} lines showing up? Is that a problem?
> > This is the result from running the utils/update_mir_test_checks.py script. The pattern is now CHECK-NEXT, and these are whitespace lines to exactly match whitespace lines in the output. @rampitec please let me know if its ok.
> This is OK, go ahead.
In future maybe re-run update_mir_test_checks first and commit it as NFC (no review required) before changing any tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119750/new/

https://reviews.llvm.org/D119750