[PATCH] D119381: [MTE] Add NT_ANDROID_TYPE_MEMTAG

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/AArch64/memtag/aarch64-note-android-memtag.test:1
+# RUN: yaml2obj -D DESC='Desc: 0d000000' %s -o %t
+# RUN: llvm-readelf --notes %t | FileCheck %s --check-prefixes=GNU,GNU-OK,ASYNC,HEAP,STACK
----------------
You can drop "aarch64" from the test file names, since you're in the AArch64 folder. Probably also can drop "memtag", although I'd be more inclined to get rid of the subdirectory now, as there aren't that many(?) memtag tests now.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/AArch64/memtag/aarch64-note-android-memtag.test:80
+        Type: NT_ANDROID_TYPE_MEMTAG
+        [[DESC]]
----------------
You should be able to do this and then omit "Desc: " from the -D values in the yaml2obj runs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119381/new/

https://reviews.llvm.org/D119381