[PATCH] D119741: [ifs] Add the invalid STRSZ test to llvm-ifs

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-ifs/binary-read-bad-vaddr.test:53
+
+--- !ELF
+FileHeader:
----------------
Rather than duplicating the YAML, you'd be better off using yaml2obj's -D option to parameterize the fields that vary between the two test cases. You can specify default values for fields using the variable defined by that option, so that you only need one -D per test case.


================
Comment at: llvm/test/tools/llvm-ifs/binary-read-bad-vaddr.test:97
+
+# ERR2: virtual address is not in any segment: 0x2000 when locating dynamic string table section contents
----------------
This is essentially identical to ERR1, but with a different value. Perhaps use FileCheck -D to parameterize the value, rather than duplicating the entire message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119741/new/

https://reviews.llvm.org/D119741