[PATCH] D119577: [BOLT][DWARF] Add ability to insert new entries in to DIE

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/lib/Core/DebugData.cpp:902
+    // Adding new Abbrevs for inserted entries.
+    if (Entries != AbbrevEntries.end())
+      for (const AbbrevEntry &Entry : Entries->second) {
----------------
nit: add braces for the `if` since the nested `for` is braced.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:603
       DIE.getAbbreviationDeclarationPtr();
+
   if (!AbbreviationDecl) {
----------------
Accidental?


================
Comment at: bolt/test/X86/insert-debug-info-entry.test:9
+
+
+; CHECK: DW_AT_GNU_addr_base
----------------
Could you add a description what the test is checking? If you are inserting a new attribute, perhaps you should check that it's introduced by BOLT and not by llc?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119577/new/

https://reviews.llvm.org/D119577