[PATCH] D119802: [HWASan] remove replacement of DbgVariableIntrinsics.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 14 18:46:27 PST 2022


fmayer requested review of this revision.
fmayer added a comment.

In D119802#3321598 <https://reviews.llvm.org/D119802#3321598>, @fmayer wrote:

> Oh hold on, maybe what we actually want (to fix this) is to replace `NewPtr` (the BitCast from `alignAndPadAlloca`) with `AI`. Sorry for jumping the gun here, the change as is is correct in that it keeps current behaviour, but that is possibly not what we want.

Nevermind, no. We actually want the cast, because otherwise we cast to the (wrong) type of the padded alloca,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119802/new/

https://reviews.llvm.org/D119802



More information about the llvm-commits mailing list